stat_smooth()
drops failed groups
#5371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5352.
Briefly, it wraps the fitting/predicting procedure in a
tryCatch()
block to rethrow errors as warnings and drops the group for which the procedure fails. This prevents one bad group stopping the fitting in all other groups.The example from #5352 with this PR (in particular, see the very last warning):
Created on 2023-07-27 with reprex v2.0.2