Update documentation and example in scale-brewer.R to reflect scale_*_distiller's non-intuitive "direction" #5381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capturing in documentation that scale_*_distiller has a non-intuitive default direction = -1, and that to reverse, user needs to specify direction = 1 Source: tidyverse#1439 tidyverse#4444
ahcyip
changed the title
ahcyip
changed the title
|
Looks good to me in principle. Is there any chance you could run |
Sorry I only edited on Github.com and I don't have the latest repo with me right now. |
|
/document |
teunbrand
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Thanks @ahcyip for the PR: it looks good to me.
Thanks @yutannihilation for running the redocumentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capturing in documentation that scale_*_distiller has a non-intuitive default direction = -1, and that to reverse, user needs to specify direction = 1
Source:
#1439
#4444