Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5396.
Briefly,
geom_violin()
callsresolution()
to determine the default width of a violin.In
resolution()
, we're (correctly) making an exception for integers and 'mapped_discrete' vectors to have resolution 1.However, the 'mapped_discrete' class got dropped from
data$x
due to amean()
operation.In this PR, we skip the mean calculation when
data$x
only has 1 unique value, thereby preserving the 'mapped_discrete' class that gets forwarded toresolution()
.Small demo:
Created on 2023-08-29 with reprex v2.0.2