Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update r4ds url #5406

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Update r4ds url #5406

merged 2 commits into from
Sep 15, 2023

Conversation

zekiakyol
Copy link
Contributor

@zekiakyol
Update r4ds url
e061332 
- This pull request updates r4ds(<https://r4ds.had.co.nz/>) to r4ds 2e (https://r4ds.hadley.nz/).
@teunbrand
Copy link
Collaborator

Thanks for the PR! Is there any chance I could convince you to run devtools::build_readme() to propagate changes from the .Rmd file to the .md file? If git flags changes in the .png images, it should be safe to not commit these, as they may be platform dependent.

@zekiakyol
Copy link
Contributor Author

You are welcome!
When I run devtools::build_readme() git flags a change in man\figures\README-example-1.png.
I think it is safer to close this pull request without merging.

@teunbrand
Copy link
Collaborator

I think it is safer to close this pull request without merging.

The PR is good, but the changes need to be propagated to the .md file. You can just not commit the change in the .png file.

@zekiakyol
run devtools::build_readme()
b5827d2 
It updates **README.md** by running `devtools::build_readme()`.
teunbrand
teunbrand approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR!

@teunbrand teunbrand merged commit 25f54d9 into tidyverse:main Sep 15, 2023
11 of 12 checks passed
@zekiakyol
Copy link
Contributor Author

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teunbrand teunbrand teunbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zekiakyol @teunbrand