Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Get started" section on the pkgdown site #5415

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

yutannihilation
Copy link
Member

Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for catching this! I wanted to include this in #5159 but couldn't figure it out right away.

@yutannihilation
Copy link
Member Author

Thanks, I too didn't know this convention until today :)

@yutannihilation yutannihilation merged commit 22ed73c into main Sep 12, 2023
11 of 12 checks passed
@yutannihilation yutannihilation deleted the yutannihilation-patch-1 branch September 12, 2023 10:37
@yutannihilation
Copy link
Member Author

Hmm, I still cannot see the "Get started" in the navvar of https://ggplot2.tidyverse.org/dev/index.html. Sorry, it seems I misunderstand the rule...

image

@yutannihilation
Copy link
Member Author

Now I see it. It seems the deployment didn't succeed at this commit.

https://github.com/tidyverse/ggplot2/actions/runs/6158393380/job/16711101201

@teunbrand
Copy link
Collaborator

The 'Get started' now shows up, so I guess this has magically resolved itself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants