Reduce panel parameter setup in facetted plots #5431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5427.
Briefly, it determines unique combinations of x/y scales and (1) only sets up panel parameters and guides and (2) renders axes for these unique combinations. These are then repeated for the duplicated combinations.
In theory, the panel's x parameters and y parameters could be setup independently to further reduce the amount of setup is performed, but the
Guide$transform
method should have access to both at the same time.Below is a reprex from the issue that shows that the x-axis is only trained and drawn once:
Created on 2023-09-21 with reprex v2.0.2
This mostly will affect plots that have many facets but no/few unique scales. Benchmark below is for an optimal case (100 panels all sharing all scales) using this PR. All the panel param setup and drawing happens after
ggplot_build()
, so I'm testing theggplot_table()
performance.Created on 2023-09-21 with reprex v2.0.2
Compared to the same benchmark for the current main branch:
To me this is a clear performance benefit in this optimal case.