Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve labeller() behavior for lookup tables #5432

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Improve labeller() behavior for lookup tables #5432

merged 1 commit into from
Sep 22, 2023

Conversation

92amartins
Copy link
Contributor

This is an attempt to fix the issue #4599

teunbrand
teunbrand requested changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it looks great! The only change I'd propose is to make the tests a little more direct.

tests/testthat/test-labellers.R Outdated Show resolved Hide resolved
@92amartins 92amartins force-pushed the 4599-improve-labeller-behavior-for-lookup-tables branch from 3070ec2 to 4e7a78c Compare September 22, 2023 13:34
teunbrand
teunbrand approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for your contribution!

@teunbrand teunbrand merged commit 69e7430 into tidyverse:main Sep 22, 2023
11 of 12 checks passed
@teunbrand teunbrand mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teunbrand teunbrand teunbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@92amartins @teunbrand