Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit rownames from aesthetic usage check #5435

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5392. It calls unrowname() on the data before checking.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 72dcfad into tidyverse:main Oct 2, 2023
11 of 12 checks passed
@teunbrand teunbrand deleted the aes_warning_rownames branch October 2, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warn_for_aes_extract_usage() fails if data has rownames
2 participants