Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minor note about the difference of the unit of size to FAQ #5446

Merged

Conversation

yutannihilation
Copy link
Member

I think it's a common case that the user wants to customize both the size of theme and that of geoms. So, probably this FAQ should have some mention about the difference of the unit.

https://ggplot2.tidyverse.org/articles/faq-customising.html#fonts

@teunbrand
Copy link
Collaborator

It might also be good to mention hat we've added a size.unit argument to geom_text() to switch the behaviour in #5260.

@thomasp85
Copy link
Member

@yutannihilation can you brush this up so we can include it in the next release

@yutannihilation
Copy link
Member Author

Thanks, but I'm yet to figure out how I can fit @teunbrand's comment into the FAQ; while size.unit is a variable tip, I think the FAQ talks about how to change the default size, and size.unit is not what the user can update by update_geom_defaults() (am I correct here?). Also, size.unit cannot change the fact that GeomLabel$default_aes$size is stored as mm. Maybe it's less confusing not to mention size.unit here? Any ideas?

@teunbrand
Copy link
Collaborator

am I correct here?

Yeah it is a parameter, not an aesthetic.

Any ideas?

Maybe mention here that 'the default size is in mm' and add to the vignette it links to that there is a metric switch?

@yutannihilation
Copy link
Member Author

Thanks. How about this one?

Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think this looks good :)

@yutannihilation
Copy link
Member Author

Thanks!

@yutannihilation yutannihilation merged commit 9367b48 into tidyverse:main Dec 15, 2023
12 checks passed
@yutannihilation yutannihilation deleted the doc/faq-customising-text-font branch December 15, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants