stat_count()
respects uniqueness of x
#5520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4609.
Briefly,
as.factor(x)
andvec_unique(x)
have different definitions of what constitutes a unique value, because theas.factor(x)
castsx
as a character, losing any small digits in doubles. This PR usesrowsum()
instead oftapply()
to count, which preserves the uniqueness as it doesn't cast the group to a factor (alsorowsum()
is a bit faster).Reprex from #4609:
Created on 2023-11-13 with reprex v2.0.2
Of course,
position_stack()
not unreasonably complains about overlapping intervals, but this is a better hint at what might be going on that the current error.