Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggplot2 3.5.0 #5592

Merged
merged 49 commits into from
Feb 23, 2024
Merged

ggplot2 3.5.0 #5592

merged 49 commits into from
Feb 23, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5588.

Currently set as draft until checks are passing and revdepcheck issues are resolved.

@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Dec 18, 2023
teunbrand and others added 28 commits December 18, 2023 15:36
@teunbrand
Fix note (#5594)
d6e45d6
@teunbrand
ingest plain patterns as lists in layer() (#5595)
fe9d5bd
@teunbrand
<AsIs> never invokes identity scale (#5597)
38c8796 
* skip AsIs scale type

* remove `scale_type.AsIs` method
@teunbrand
Bugfix guide_axis_theta() label size (#5598)
29ce30a 
* Measure labels directly

* Accept new snapshot
@teunbrand
flip justification along with angle (#5600)
ed4971e
@thomasp85
Run revdepcheck
2f2633c
@teunbrand
Missing Scale$get_transformation() (#5607)
954e2f4 
* Use `Scale$get_transformation()` more

* Only inverse transform is there is an actual transform
@teunbrand
swap vec_in() for %in% (#5606)
1b142f9
@teunbrand
explicitly ignore empty arguments (#5604)
f15a332
@teunbrand
Fix partial match in deprecated guide arguments (#5603)
9d1d9c6 
* fix partial match bug

* report more informative call
@teunbrand
Guide custom theme (#5602)
49d7a8d 
* Apply #5554 to `guide_custom()`

* build in early exit
@teunbrand
Protection for position scale's call parameter (#5605)
c700dc8 
* protect against exotic calls

* misplaced parenthesis

* circumvent try_fetch
@teunbrand
fix misplaced parenthesis
3c571b1
@thomasp85
update revdepcheck
63cfa5e
@teunbrand
propagate spacing (#5615)
47b4bd0
@teunbrand
Text key justification (#5618)
0ee63c3 
* `compute_just()` returns non-characters as-is

* `rotate_just()` handles character justification

* better text legend justification
@thomasp85
adhere to strip placement even if the axis is empty (#5630)
9c15f81
@teunbrand
Set vjust = 1 for axis.title.y.right. (#5629)
78125e0 
* change right axis title vjust

* accept visual changes

* Add news bullet
@teunbrand
Revert renaming Scale$trans to Scale$transformation (#5626)
358325d 
* revert renaming `Scale$trans` to `Scale$transformation`

* use `get_transformation()` more consistently

* use `get_transformation()` for y in function stat
@teunbrand
unclass raster data before calculating resolution (#5638)
0c992dc
@teunbrand
remove censoring date breaks (#5636)
8cbc148
@teunbrand
put deprecated arg last (#5635)
dad3573
@teunbrand
fill potentially missing args (#5634)
c834279
@teunbrand
drop empty panels from bar width calculation (#5633)
5bfecd2
@teunbrand
redocument
75d3197
@thomasp85
another revdepcheck
e1fb4a3
@teunbrand
setup parameters before declaring key (#5643)
26de56e
@teunbrand
Do not make more than 10k points for a line (#5644)
2d1f31c
teunbrand and others added 18 commits January 16, 2024 11:24
@teunbrand
Drop zeroGrob() guides (#5645)
d5c2f1f 
* drop empty guides

* add test
@teunbrand
Only throw scale training errors when the Range class is the expected…
61f9a0a 
… one (#5649)
@teunbrand
Change legend tick length inheritance (#5652)
6afb5d7 
* `legend.ticks.length` inherits from `legend.key.size`

* set `legend.ticks.length` defaults in theme

* remove `legend.ticks.length` defaults from guides
@teunbrand
Don't strip classes in Geom$use_defaults() (#5657)
7a4af1e 
* Use `vec_cbind()` instead of data.frame assignment

* ignore rownames in test

* Add test for AsIs class
@teunbrand
Simplify legend layout logic (#5648)
5c550e7 
* extract title logic in `legend_add_title()`

* `guide_custom()` uses title logic

* simplify legend layout

* borrow legend's setup_elements method

* make `add_title` a ggproto method

* fix messy merge conflict

* document `add_title` method

* `unique()` --> `unique0()`
@teunbrand
Add missing element_grob()
3d5e9d2
@teunbrand
Balance geom label whitespace (#5663)
87abade 
* balance labels

* get `vjust` right

* update snapshot
@teunbrand
Restore legend.byrow (#5662)
617c336 
* add `elements` to `arrange_layout`

* Fix `byrow`

* add test
@thomasp85
redo revdepcheck
fa6d68d
@teunbrand
Radial inner radius (#5679)
7378156 
* rename `donut` -> `inner.radius`

* regenerate docs
@teunbrand
discard empty colourbar (#5681)
0e4394d
@teunbrand
revert 5657, instead explicitly restore AsIs (#5683)
9e67b94
@thomasp85
rerun revdepcheck
9f2b8ba
@teunbrand
theta/r guides get theta/r theme elements (#5680)
389315e 
* swap theme suffix depending on `theta`

* pass theme properly in `guide_axis_theta()`

* add `theta` and `r` theme elements

* axis.text.r has symmetrical margins

* use new suffixes

* update tests

* update docs
@teunbrand
add section about guide extensions (#5693)
6836936
@thomasp85
one more rerun
9592cd6
@thomasp85
update copyright
7e63435
@thomasp85
update cran-comments
a6f1a7c
@thomasp85 thomasp85 marked this pull request as ready for review February 23, 2024 09:35
@thomasp85 thomasp85 merged commit 7c9a73a into main Feb 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.0
Development

Successfully merging this pull request may close these issues.

Release ggplot2 3.5.0
2 participants
@teunbrand @thomasp85