Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flip justification along with angle #5600

Merged
merged 1 commit into from
Dec 19, 2023
Merged

flip justification along with angle #5600

merged 1 commit into from
Dec 19, 2023

Conversation

teunbrand
Copy link
Collaborator

This PR to the RC aims to fix #5599.

The reprex from that issue with correct label justification:

devtools::load_all("~/packages/ggplot2")
#> ℹ Loading ggplot2

ggplot(mtcars, aes(x = seq_along(disp), y = disp)) +
  geom_col() +
  geom_text(aes(y = Inf, label = rownames(mtcars)), hjust = 1, angle = 90) +
  coord_radial(rotate_angle = TRUE)

Created on 2023-12-18 with reprex v2.0.2

@teunbrand teunbrand changed the base branch from main to rc/3.5.0 December 18, 2023 22:05
thomasp85
thomasp85 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit ed4971e into tidyverse:rc/3.5.0 Dec 19, 2023
12 checks passed
@teunbrand teunbrand deleted the radial_justification branch December 19, 2023 10:02
@teunbrand teunbrand mentioned this pull request Dec 20, 2023
Closed
thomasp85 pushed a commit that referenced this pull request Feb 23, 2024
@teunbrand @thomasp85
flip justification along with angle (#5600)
324e055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using coord_radial(rotate_angle = TRUE) does not adjust justification.
2 participants
@teunbrand @thomasp85