Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text key justification #5618

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Text key justification #5618

merged 3 commits into from
Jan 4, 2024

Conversation

teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented Jan 2, 2024 •
edited
Loading

This PR to the RC aims to fix #5614.

Briefly, the issue at hand is that the draw_key_text() and draw_key_label() functions did not know how to handle character-based justification such as "right" or "outward". This PR fixes that by resolving the justification through compute_just().

As a related change, rotate_just() now also handles character justification.

The reprex from #5614:

devtools::load_all("~/packages/ggplot2/")
#> ℹ Loading ggplot2

mycars <- mtcars
mycars$name <- rownames(mycars)

ggplot(mycars, aes(wt, mpg, label = name)) +
  geom_text(aes(size = wt), nudge_x = -0.1, hjust = "right")

Created on 2024-01-02 with reprex v2.0.2

@teunbrand teunbrand changed the base branch from main to rc/3.5.0 January 2, 2024 09:16
@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Jan 2, 2024
thomasp85
thomasp85 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 0ee63c3 into tidyverse:rc/3.5.0 Jan 4, 2024
12 checks passed
@teunbrand teunbrand deleted the text_key_justification branch January 4, 2024 08:01
@teunbrand teunbrand mentioned this pull request Jan 4, 2024
Closed
thomasp85 pushed a commit that referenced this pull request Feb 23, 2024
@teunbrand @thomasp85
Text key justification (#5618)
b5e7383 
* `compute_just()` returns non-characters as-is

* `rotate_just()` handles character justification

* better text legend justification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.0
Development

Successfully merging this pull request may close these issues.

Error with hjust = "right" when used together with size aesthetic
2 participants
@teunbrand @thomasp85