Backward compatibility for trans
field deprecation: attempt 1
#5621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix some reverse dependency problems.
To briefly describe the problem: people are using
foo <- Scale$trans
all over their code. We have removed theScale$trans
field in #5566, in favour of theScale$transformation
field. All this code is now broken.Since
trans
is not a function, it is not easy to deprecate elegantly. This PR uses some active binding voodoo witchcraft to (1) redirectScale$trans
toScale$transformation
and (2) issue a deprecation message when usingScale$trans
. This would allow people's code to continue functioning and, by virtue of the annoying-ness of warning messages, hopefully bully them into using the new field.I've left this PR as a draft, since active bindings are not my bread and butter and I'd like some scrutinizing eyes on this.
A demonstration:
Created on 2024-01-02 with reprex v2.0.2