Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns in geom_sf() #5717

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Patterns in geom_sf() #5717

merged 3 commits into from
Feb 27, 2024

Conversation

teunbrand
Copy link
Collaborator

@teunbrand teunbrand commented Feb 27, 2024

This PR aims to fix #5716.

Briefly, it fixes a small oversight where we forgot to switch from alpha() to fill_alpha() in #5299.
Reprex from issue:

devtools::load_all("~/packages/ggplot2")
#> ℹ Loading ggplot2

grad <- grid::linearGradient(c("red", "black"))

nc <- sf::st_read(system.file("shape/nc.shp", package = "sf"), quiet = TRUE)
ggplot(nc) +
  geom_sf(fill = grad)

Created on 2024-02-27 with reprex v2.1.0

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 9b4d4fe into tidyverse:main Feb 27, 2024
12 checks passed
@teunbrand teunbrand deleted the sf_pattern branch February 27, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geom_sf() does not accept patterns
2 participants