Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention secondary transformation must be *strictly* monotonic #5720

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5579.

Briefly, the error mentions that the transformation must be strictly monotonic, as well as the docs.

@teunbrand teunbrand requested a review from thomasp85 March 4, 2024 09:56
@teunbrand teunbrand added this to the ggplot2 3.5.1 milestone Mar 5, 2024
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit c8e2544 into tidyverse:main Mar 18, 2024
12 checks passed
@teunbrand teunbrand deleted the sec_axis_monotonic branch March 18, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate test for monotonic function causes ecdf to be an invalid transformation in second x axis
2 participants