Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove palette from manual scale docs #5724

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Remove palette from manual scale docs #5724

merged 1 commit into from
Mar 18, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5625.

It just removes palette from the documentation that scale_{aes}_manual() inherits from discrete_scale().

@teunbrand teunbrand requested a review from thomasp85 March 4, 2024 09:53
@teunbrand teunbrand added this to the ggplot2 3.5.1 milestone Mar 5, 2024
thomasp85
thomasp85 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 1f49bb6 into tidyverse:main Mar 18, 2024
12 checks passed
@teunbrand teunbrand deleted the remove_manual_palette branch March 18, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.1
Development

Successfully merging this pull request may close these issues.

scale_color_manual does not support palette even though documentation suggests otherwise
2 participants
@teunbrand @thomasp85