Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geom aesthetics based on theme #5833

Merged
merged 56 commits into from
Aug 27, 2024
Merged

Geom aesthetics based on theme #5833

merged 56 commits into from
Aug 27, 2024

Commits on Apr 5, 2024

  1. draft new geom element in themes

    @teunbrand
    teunbrand committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    08300bd View commit details
    Browse the repository at this point in the history

  2. plumbing for providing theme to Geom$use_defaults()

    @teunbrand
    teunbrand committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8c24ab9 View commit details
    Browse the repository at this point in the history

  3. make from_theme() as eval helper

    @teunbrand
    teunbrand committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    60af7a3 View commit details
    Browse the repository at this point in the history

  4. Evaluate default aesthetics from theme

    @teunbrand
    teunbrand committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f551c8b View commit details
    Browse the repository at this point in the history

  5. allow user-specified from_theme()

    @teunbrand
    teunbrand committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ced8c15 View commit details
    Browse the repository at this point in the history

  6. plumbing for guides to observe theme

    @teunbrand
    teunbrand committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    659fd09 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. reoxygenate

    @teunbrand
    teunbrand committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2cec833 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Add text settings

    @teunbrand
    teunbrand committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5637501 View commit details
    Browse the repository at this point in the history

  2. Add text settings

    @teunbrand
    teunbrand committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2d28202 View commit details
    Browse the repository at this point in the history

  3. accept minor fontsize difference (11.04pt -> 11.00pt)

    @teunbrand
    teunbrand committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5f2ebf9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'theme_geom_defaults' of https://github.com/teunbrand/gg… 

    …plot2 into theme_geom_defaults
    @teunbrand
    teunbrand committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    87af93e View commit details
    Browse the repository at this point in the history

  5. temporarily disable sf_grob() default lookups

    @teunbrand
    teunbrand committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f503409 View commit details
    Browse the repository at this point in the history

  6. temporary shim for colour mixing

    @teunbrand
    teunbrand committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    f08fcb6 View commit details
    Browse the repository at this point in the history

  7. Get all colour/fill/linewidth from theme

    @teunbrand
    teunbrand committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b5ffd32 View commit details
    Browse the repository at this point in the history

  8. test theme has geom element

    @teunbrand
    teunbrand committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    93a9258 View commit details
    Browse the repository at this point in the history

  9. adapt tests

    @teunbrand
    teunbrand committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5e9136f View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. resolve merge conflict 

    Merge branch 'main' into theme_geom_defaults

# Conflicts:
#	R/geom-.R
#	R/geom-sf.R
    @teunbrand
    teunbrand committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    962004e View commit details
    Browse the repository at this point in the history

  2. geom_sf() has themed defaults

    @teunbrand
    teunbrand committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6185e82 View commit details
    Browse the repository at this point in the history

  3. we don't expect complete themes anymore

    @teunbrand
    teunbrand committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    df571c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. shim auto-replaces itself when exported from scales

    @teunbrand
    teunbrand committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    92d2bbb View commit details
    Browse the repository at this point in the history

  2. theme defaults for point size/shape

    @teunbrand
    teunbrand committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    124dd5f View commit details
    Browse the repository at this point in the history

  3. boxplot point shape/size default from GeomBoxplot$default_aes

    @teunbrand
    teunbrand committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    0ff6078 View commit details
    Browse the repository at this point in the history

  4. accept larger points in large theme snapshots

    @teunbrand
    teunbrand committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    2dd3f37 View commit details
    Browse the repository at this point in the history

  5. document

    @teunbrand
    teunbrand committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    377a82c View commit details
    Browse the repository at this point in the history

  6. Point to theme setting in update_geom_defaults()

    @teunbrand
    teunbrand committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e584978 View commit details
    Browse the repository at this point in the history

  7. document from_theme()

    @teunbrand
    teunbrand committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    1143a9f View commit details
    Browse the repository at this point in the history

  8. add news bullet

    @teunbrand
    teunbrand committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    afca781 View commit details
    Browse the repository at this point in the history

  9. Update R/geom-pointrange.R 

    Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com>
    @teunbrand @thomasp85
    teunbrand and thomasp85 committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    f0b4279 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Run revdepcheck

    @thomasp85
    thomasp85 committed May 15, 2024
    Configuration menu
    Copy the full SHA
    b0251f3 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. resolve merge conflict 

    Merge branch 'main' into theme_geom_defaults

# Conflicts:
#	R/theme-elements.R
#	R/theme.R
#	man/theme.Rd
    @teunbrand
    teunbrand committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0a99ec7 View commit details
    Browse the repository at this point in the history

  2. implement @yutannihilation's suggestion

    @teunbrand
    teunbrand committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d41758f View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. resolve merge conflict 

    Merge branch 'main' into theme_geom_defaults

# Conflicts:
#	R/geom-.R
#	R/geom-sf.R
#	R/guide-legend.R
#	R/layer.R
    @teunbrand
    teunbrand committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    ddfba94 View commit details
    Browse the repository at this point in the history

  2. run revdepcheck

    @thomasp85
    thomasp85 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    99a3b58 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'main' into theme_geom_defaults

    @teunbrand
    teunbrand committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6741230 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. resolve merge conflict 

    Merge branch 'main' into theme_geom_defaults

# Conflicts:
#	R/geom-sf.R
#	R/theme-defaults.R
#	revdep/README.md
#	revdep/cran.md
#	revdep/failures.md
#	revdep/problems.md
    @teunbrand
    teunbrand committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    7762341 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. revdepcheck once again

    @thomasp85
    thomasp85 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    dbea0a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. protect against missing theme

    @teunbrand
    teunbrand committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    789ec08 View commit details
    Browse the repository at this point in the history

  2. skip empty sf layers

    @teunbrand
    teunbrand committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0d682f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. getter for geom defaults

    @teunbrand
    teunbrand committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e6afd5c View commit details
    Browse the repository at this point in the history

  2. add test

    @teunbrand
    teunbrand committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6a08f2d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into theme_geom_defaults

    @teunbrand
    teunbrand committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f87e548 View commit details
    Browse the repository at this point in the history

  4. tmp

    @teunbrand
    teunbrand committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f1fae8e View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. add linetype to element_geom()

    @teunbrand
    teunbrand committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    b73f1d2 View commit details
    Browse the repository at this point in the history

  2. geom_path() treats integer 1L as solid (in addition to numeric 1)

    @teunbrand
    teunbrand committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c511902 View commit details
    Browse the repository at this point in the history

  3. get linetype from theme

    @teunbrand
    teunbrand committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    7ffab68 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'theme_geom_defaults' of https://github.com/teunbrand/gg… 

    …plot2 into theme_geom_defaults
    @teunbrand
    teunbrand committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    43037b5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into theme_geom_defaults

    @teunbrand
    teunbrand committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    e728d19 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'main' into theme_geom_defaults

    @teunbrand
    teunbrand committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    e718db1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into theme_geom_defaults

    @teunbrand
    teunbrand committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b571625 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. swap thin/thick for linewidth/borderwidth and distinguish linetype an… 

    …d bordertype
    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ee54458 View commit details
    Browse the repository at this point in the history

  2. disseminate new params

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a9f259e View commit details
    Browse the repository at this point in the history

  3. point stroke counts as border

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    52fc7b7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'theme_geom_defaults' of https://github.com/teunbrand/gg… 

    …plot2 into theme_geom_defaults
    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0b8ac05 View commit details
    Browse the repository at this point in the history

  5. redocument

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ee60f6d View commit details
    Browse the repository at this point in the history

  6. Fix example

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    77ef62c View commit details
    Browse the repository at this point in the history

  7. deduplicate argument documentation

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    e689e08 View commit details
    Browse the repository at this point in the history