Refactor applying defaults in geom_sf()
#5834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a roadblock for #5833 and fixes #3164 (comment).
Briefly, applying the default aesthetics for
geom_sf()
happended insf_grob()
instead of the typicalGeom$use_defaults()
.This brings
geom_sf()
back in line with other geoms, by applying the defaults in theuse_defaults()
method.The
GeomSf$use_defaults()
method just calls that method from other Geoms for different parts of the data, depending on the geometry type.This should solve a roadblock for #5833 where themeable defaults are applied in the
use_defaults()
method.