Copy angle heuristic for more guides. #5957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4594.
Briefly it copies the heuristic from
guide_axis(angle)
to the following guides:guide_colourbar()
,guide_coloursteps()
andguide_bins()
.Note that angle heuristic is applied in
GuideLegend$override_elements()
even though GuideLegend does not use the heuristic (per #4594 (comment)). While not applied in GuideLegend, it is inherited by and used in child guides.Some examples. Note that for labels placed close to the edge (1st example '6000'), the label may escape the allocated space, but there is no easy fix for this at the moment.
Created on 2024-06-25 with reprex v2.1.0