move make_summary_fun()
to setup_params()
#5971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4647 (comment).
Briefly,
stat_summary()
andstat_summary_bin()
usemake_summary_fun()
once per panel/group respectively, whereas it should be used once per layer. This PR moves the use of that function to thesetup_params()
method, so that we don't encounter the message multiple times, as per #4647 (comment).An example:
Created on 2024-07-03 with reprex v2.1.0