facet_grid(space = "free")
can work with coord_fixed()
#5977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4584.
Briefly, we set the ratio of a panel when
space = "free"
and usingcoord_fixed()
.Previously, in #4432 it was prohibited to set an aspect ratio in the theme and using free space.
However, there is a subtlety here. The theme aspect ratio controls the width/height of panels directly and you cannot reasonably set this ratio for multiple panels of disparate sizes. So theme aspect ratios still aren't allowed. The coord aspect ratio controls the data proportion that is consistent with free facet space, so this should be allowed.
Created on 2024-07-05 with reprex v2.1.0