Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove {glue} dependency #5988

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix part of #5986 (comment).

It removes the {glue} dependency, which isn't technically required anymore since we do most text interpolation for messages now through the {cli} package. This PR mostly replaces residual {glue} functions with paste0().
Tested with {glue} uninstalled.

Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@teunbrand
Copy link
Collaborator Author

Thanks for the review!

@teunbrand teunbrand merged commit cd9410c into tidyverse:main Jul 10, 2024
11 checks passed
@teunbrand teunbrand deleted the remove_glue_dependency branch July 10, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants