Fix expression labels in guide_coloursteps()
and guide_bins()
#6007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6005.
Briefly, internally we dance around
<expression>
labels by casting them to lists of expressions when storing them in<data.frame>
s and later unpacking such lists to expressions when handing them off to {grid}. I forgot to do this forguide_coloursteps()
andguide_bins()
, which have very custom code for getting the keys from the scale. This PR rectifies that.Reprex from the issue:
Created on 2024-07-18 with reprex v2.1.1