Ignore empty non-mapped aesthetics #6011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #6009.
Briefly, when passing
NULL
or 0-length aesthetics inlayer()
it will raise a warning. Previously, this would raise an error.As far as I know, there isn't any situation in which it is desirable to pass a 0-length aesthetic. Even if the data has 0-rows, nothing should be shown and no information is to be derived from a 0-length aesthetic. Note that this PR only applies to aesthetics passed outside the
aes()
function.