Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update economics script & data #6019

Closed
wants to merge 1 commit into from
Closed

Update economics script & data #6019

wants to merge 1 commit into from

Conversation

bwu62
Copy link

@bwu62 bwu62 commented Jul 31, 2024

Update economics.R script to use updated FRED file links and process correctly, then ran script to generated updated economics and economics_long data frames.

I recently found myself wanting to use this data set and was disappoint to learn it hadn't been updated in nearly a decade.

@teunbrand
Copy link
Collaborator

teunbrand commented Aug 2, 2024

Thanks for the PR! I can see why it might be useful to have an updated dataset, but ultimately this dataset exists in ggplot2 to make it easier to show example timeseries plots rather than serving as a reputable source of this data. @thomasp85 could you advise on ggplot2's policy on updating datasets (in lieu thereof, just your thoughts)?

Relevant prior discussion around this topic in #3146 and #2962.

@clauswilke
Copy link
Member

I don't think the dataset should be updated. Its main purpose is to be used for documentation and reproducible examples and nobody would benefit if those existing plots suddenly change. There is no reason for this dataset to be kept up-to-date. We're also routinely using the mtcars dataset which has data from 1974.

@bwu62 bwu62 closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants