Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up orphan functions and tiny one-off helpers #6022

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Clean up orphan functions and tiny one-off helpers #6022

wants to merge 46 commits into from

Commits on Aug 1, 2024

  1. replace single use internal functions

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    20fa50f View commit details
    Browse the repository at this point in the history

  2. move helper to location where it is used

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0bfbcc3 View commit details
    Browse the repository at this point in the history

  3. remove orphan functions

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    79866e8 View commit details
    Browse the repository at this point in the history

  4. replace and remove redundant adjust_breaks() function

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    a5a1ce5 View commit details
    Browse the repository at this point in the history

  5. replace df_rows() with vec_slice()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c4c61de View commit details
    Browse the repository at this point in the history

  6. inline f_as_facets_list()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    2ce92fb View commit details
    Browse the repository at this point in the history

  7. inline find_origin()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    15241a6 View commit details
    Browse the repository at this point in the history

  8. inline firstUpper()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    2e9b8c2 View commit details
    Browse the repository at this point in the history

  9. replace has_name()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0cca7a3 View commit details
    Browse the repository at this point in the history

  10. replace interleave() with vec_interleave()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5f4a4b9 View commit details
    Browse the repository at this point in the history

  11. remove cunion()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    79fa0b1 View commit details
    Browse the repository at this point in the history

  12. inline is_dotted_var()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    abc62dd View commit details
    Browse the repository at this point in the history

  13. inline is_facets()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4a3ffff View commit details
    Browse the repository at this point in the history

  14. inline is_labeller()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9976913 View commit details
    Browse the repository at this point in the history

  15. inline is_missing_arg()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b4e0d80 View commit details
    Browse the repository at this point in the history

  16. replace is_npc() (we partially backport unitType())

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    be4081a View commit details
    Browse the repository at this point in the history

  17. inline is_scalar_numeric()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    70cc78b View commit details
    Browse the repository at this point in the history

  18. inline is.margin()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    997d9fe View commit details
    Browse the repository at this point in the history

  19. inline is.sec_axis()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1bdc20d View commit details
    Browse the repository at this point in the history

  20. inline is.subclass()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b044fa2 View commit details
    Browse the repository at this point in the history

  21. inline is_triple_bang()

    @teunbrand
    teunbrand committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    490c9c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. remove justify_grobs()

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4ebdea3 View commit details
    Browse the repository at this point in the history

  2. inline label_variable()

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e086817 View commit details
    Browse the repository at this point in the history

  3. more responsibility for parse_axes_labeling(), so that it is less d… 

    …istracting
    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    024a1b6 View commit details
    Browse the repository at this point in the history

  4. remove resolve_guide()

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    b2de86e View commit details
    Browse the repository at this point in the history

  5. inline revalue

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    f7c8cb6 View commit details
    Browse the repository at this point in the history

  6. simplify scale_flip_position()

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3232471 View commit details
    Browse the repository at this point in the history

  7. remove as.quoted() (note there is still as_quoted())

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    37da401 View commit details
    Browse the repository at this point in the history

  8. replace simplify_formula() with simplify()

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6ac62cf View commit details
    Browse the repository at this point in the history

  9. inline single_value()

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    db6feb8 View commit details
    Browse the repository at this point in the history

  10. inline update_guides()

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    e75c6d6 View commit details
    Browse the repository at this point in the history

  11. inline is_column_vec() and better name for validate_column_vec()

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4739a12 View commit details
    Browse the repository at this point in the history

  12. remove/replace wrap_as_facets_list() (by compact_facets()

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    47e36e2 View commit details
    Browse the repository at this point in the history

  13. finishing touches

    @teunbrand
    teunbrand committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d74f6a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. resolve merge conflicts 

    Merge branch 'main' into orphan_functions

# Conflicts:
#	R/coord-sf.R
#	R/margins.R
#	R/utilities.R
    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8621926 View commit details
    Browse the repository at this point in the history

  2. parse_axes_labeling uses parent call

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2f1f42f View commit details
    Browse the repository at this point in the history

  3. elaborate on regex pattern

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    276e6a2 View commit details
    Browse the repository at this point in the history

  4. Revert "inline is_labeller()" 

    This reverts commit 9976913.
    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2978d4d View commit details
    Browse the repository at this point in the history

  5. Revert "inline is.sec_axis()" 

    This reverts commit 1bdc20d.
    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    037c1ae View commit details
    Browse the repository at this point in the history

  6. Revert "replace single use internal functions" 

    This reverts commit 20fa50f.
    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8076706 View commit details
    Browse the repository at this point in the history

  7. Collection of test functions for user-facing components

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    049db27 View commit details
    Browse the repository at this point in the history

  8. apply tests when applicable

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ae2561b View commit details
    Browse the repository at this point in the history

  9. redocument

    @teunbrand
    teunbrand committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    3be8e6d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. abolish uniquecols()'s rownames

    @teunbrand
    teunbrand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    13b8d36 View commit details
    Browse the repository at this point in the history

  2. move is.*() functions to class definitions

    @teunbrand
    teunbrand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d7092aa View commit details
    Browse the repository at this point in the history

  3. resolve merge conflict 

    Merge branch 'main' into orphan_functions

# Conflicts:
#	tests/testthat/_snaps/utilities.md
    @teunbrand
    teunbrand committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    16b35e9 View commit details
    Browse the repository at this point in the history