Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct misleading error #6043

Merged
merged 2 commits into from
Aug 15, 2024
Merged

correct misleading error #6043

merged 2 commits into from
Aug 15, 2024

Conversation

catalamarti
Copy link
Contributor

fixes #4460

thomasp85
thomasp85 requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs a small wording change in the test

tests/testthat/test-utilities-break.R Outdated Show resolved Hide resolved
@catalamarti @thomasp85
Update tests/testthat/test-utilities-break.R
f32d5cb 
Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com>
thomasp85
thomasp85 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasp85 thomasp85 merged commit 19d4550 into tidyverse:main Aug 15, 2024
11 checks passed
@thomasp85
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

misleading error message thrown by cut_interval()
2 participants
@catalamarti @thomasp85