Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check type for date_breaks and date_minor_breaks #6044

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

check type for date_breaks and date_minor_breaks #6044

wants to merge 5 commits into from

Conversation

RodDalBen
Copy link

check type for date_breaks and date_minor_breaks #5880

thomasp85
thomasp85 requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can I get you to add two unit tests that checks for the correct behaviour on these cases

@teunbrand
Copy link
Collaborator

teunbrand commented Sep 10, 2024 •
edited
Loading

Added tests and check for date_labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 Awaiting requested review from thomasp85

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RodDalBen @teunbrand @thomasp85