Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geom_function(): x-axis title produced automatically where no data is added #6047

Merged

Conversation

phispu
Copy link
Contributor

@phispu phispu commented Aug 15, 2024

Fixes #5647

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a small change requested

NEWS.md Outdated
@@ -1,5 +1,8 @@
# ggplot2 (development version)

* Fixed bug in `geom_smooth()` so x-axis title now produced automatically
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed bug in `geom_smooth()` so x-axis title now produced automatically
* Fixed bug in `stat_function()` so x-axis title now produced automatically

@phispu
Copy link
Contributor Author

phispu commented Aug 15, 2024

Nice catch - updated!

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasp85 thomasp85 merged commit 633e350 into tidyverse:main Aug 15, 2024
11 checks passed
@thomasp85
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geom_function does not produce a x axis title where no data is added
2 participants