Fix some lints in the tests folder
#6051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
reviewed
Aug 20, 2024
tests/testthat/test-geom-boxplot.R
Outdated
| @@ -73,7 +73,7 @@ test_that("boxes with variable widths do not overlap", { | |||
| d <- get_layer_data(p)[c("xmin", "xmax")] | |||
| xid <- find_x_overlaps(d) | |||
|
|
|||
| expect_false(any(duplicated(xid))) | |||
| expect_false(anyDuplicated(xid) > 0) | |||
There was a problem hiding this comment.
I get that anyDuplicated() is more efficient, but the mental effort to understand what this expectation is doing is increased by this change.
Suggested change
| expect_false(anyDuplicated(xid) > 0) | |
| expect_equal(anyDuplicated(xid), 0) |
| @@ -32,7 +32,7 @@ test_that("rectangles are dodged", { | |||
| p <- ggplot(df, aes(xmin = xmin, xmax = xmax, ymin = ymin, ymax = ymax)) + | |||
| geom_rect(aes(fill = fill), position = "dodge2", alpha = 0.8) | |||
|
|
|||
| expect_false(any(duplicated(find_x_overlaps(get_layer_data(p))))) | |||
| expect_false(anyDuplicated(find_x_overlaps(get_layer_data(p))) > 0) | |||
There was a problem hiding this comment.
Suggested change
| expect_false(anyDuplicated(find_x_overlaps(get_layer_data(p))) > 0) | |
| expect_equal(anyDuplicated(find_x_overlaps(get_layer_data(p))), 0) |
| @@ -44,7 +44,7 @@ test_that("cols at the same x position are dodged", { | |||
| p <- ggplot(df, aes(1, n, fill = x)) + | |||
| geom_col(position = "dodge2", alpha = 0.5) | |||
|
|
|||
| expect_false(any(duplicated(find_x_overlaps(get_layer_data(p))))) | |||
| expect_false(anyDuplicated(find_x_overlaps(get_layer_data(p))) > 0) | |||
There was a problem hiding this comment.
Suggested change
| expect_false(anyDuplicated(find_x_overlaps(get_layer_data(p))) > 0) | |
| expect_equal(anyDuplicated(find_x_overlaps(get_layer_data(p))), 0) |
|
Fair enough, I also think |
teunbrand
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #6050 but used
flint::fix_dir("tests")this time (to avoid having too many changed files in the same PR).Changes include:
expect_equal(names(x), ...) -> expect_named(x, ...)expect_equal(x, NULL) -> expect_null(x)expect_equal(x, TRUE) -> expect_true(x)and more.