Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos layer and geom_text docs #6053

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

collinberke
Copy link
Contributor

I was reading the geom_text() docs and came across these minor typos. Feel free to reject or modify any change that goes against the original intent of what was originally written.

Thanks for maintaining this awesome package!

@collinberke
Copy link
Contributor Author

collinberke commented Aug 21, 2024

I just realized I didn't include all the files from devtools::document(), since many functions use @inheritParams layer. If I need to back this out and resubmit, let me know.

@teunbrand
Copy link
Collaborator

Hi there, thanks for the PR! It would be nice to regenerate all the relevant docs. I don't think there is a need to back out / resubmit. You could just add a second commit to the same branch and push again, at which point this PR would update with the latest changes.

@collinberke
Copy link
Contributor Author

@teunbrand , I just added the missing files in 6b557c4.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasp85 thomasp85 merged commit c9dce8a into tidyverse:main Aug 23, 2024
13 checks passed
@thomasp85
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants