Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency of naming internal functions #6072

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Improve consistency of naming internal functions #6072

wants to merge 13 commits into from

Commits on Sep 3, 2024

  1. rename validate_facets() to check_facets()

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    88032b9 View commit details
    Browse the repository at this point in the history

  2. write prevalidation/postvalidation as checks

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0d51dd6 View commit details
    Browse the repository at this point in the history

  3. more responsibility for check_nondata_cols()

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    64e0720 View commit details
    Browse the repository at this point in the history

  4. check_subclass() is actually validator

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    da57ff9 View commit details
    Browse the repository at this point in the history

  5. path checker is validator

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a1d8b5a View commit details
    Browse the repository at this point in the history

  6. plot_dev is a validator

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    690255b View commit details
    Browse the repository at this point in the history

  7. check_breaks_labels() has no return value

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7b71045 View commit details
    Browse the repository at this point in the history

  8. make check_scale_type() consistent

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    e593833 View commit details
    Browse the repository at this point in the history

  9. validate_theme/element() is a check

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    befd083 View commit details
    Browse the repository at this point in the history

  10. update labeller deprecation message

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c2487de View commit details
    Browse the repository at this point in the history

  11. check_labeller() performs an update

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8533322 View commit details
    Browse the repository at this point in the history

  12. check_linewidth() performs an update

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a2c6cf1 View commit details
    Browse the repository at this point in the history

  13. check_polar_guide() is validator

    @teunbrand
    teunbrand committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    981509e View commit details
    Browse the repository at this point in the history