Fix mistake in alignment docs for geom_text()
#6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,8 +31,8 @@ | |||
| #' | |||
| #' @section Alignment: | |||
| #' You can modify text alignment with the `vjust` and `hjust` | |||
| #' aesthetics. These can either be a number between 0 (right/bottom) and | |||
| #' 1 (top/left) or a character (`"left"`, `"middle"`, `"right"`, `"bottom"`, | |||
There was a problem hiding this comment.
There's no problem with this fix, but I personally prefer "left/top" to match the order of "right/bottom". What do you think?
There was a problem hiding this comment.
I like the order matching part, but it should be left/bottom & right/top then
There was a problem hiding this comment.
Ah, sorry, you are right. For some reason, I looked at the old description...
yutannihilation
approved these changes
Sep 9, 2024
|
Thansk for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6033. The title pretty much covers the PR's content.