Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ground_segmentation_evaluator #528

Open
wants to merge 67 commits into
base: develop
Choose a base branch
from

Conversation

nanoshimarobot
Copy link

@nanoshimarobot nanoshimarobot commented Jul 23, 2024

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Description

Add ground segmentation evaluator scenario.
This evaluator has two types of ground truth data.

  • annotated pcd
    *.pcd.bin files located in t4_dataset/sample/data/LIDAR_CONCAT/ and the data has semantic label, provided by #107.
  • annotated rosbag
    The rosbag data in the input_bag contains annotated pointcloud data, captured from sources such as AWSIM.

How to review this PR

Please download this driving_log_replayer_data for ground_segmentaion evaluation: TIERIV_INTERNAL_LINK
That data has only annotated pcd data, so please also check this annotated rosbag data: TIERIV_INTERNAL_LINK

Please download this driving_log_replayer_data for ground_segmentaion evaluation : TIERIV_INTERNAL_LINK
There are separate scenario.yaml and input_bag files for each mode, as shown in the image below:
Screenshot from 2024-08-19 15-41-36
Screenshot from 2024-08-19 15-41-44
Therefore, for testing, please modify each name to 'scenario.yaml' and 'input_bag/' before running the tests.

Others

  • When running ground_segmentation in 'annotated_rosbag' mode, it is necessary to modify the sensing module of autoware.universe as follows:
    https://github.com/autowarefoundation/autoware.universe/blob/main/sensing/autoware_pointcloud_preprocessor/src/filter.cpp#L383-L390

         if (utils::is_data_layout_compatible_with_point_xyzi(*cloud)) {
          RCLCPP_ERROR(
            get_logger(),
            "The pointcloud layout is compatible with PointXYZI. You may be using legacy "
            "code/data");
        }
    
        // return; <- comment out!
    }
    
  • When running ground_segmentation in 'annotated_pcd' mode, it is necessary to reduce the rosbag play rate because the evaluation process takes longer than the ground_segmentation process in this mode.
    dlr simulation run -p ground_segmentation --launch_args play_rate:=0.1

@nanoshimarobot nanoshimarobot marked this pull request as draft July 23, 2024 02:46
@nanoshimarobot nanoshimarobot marked this pull request as ready for review July 26, 2024 05:42
@badai-nguyen
Copy link

@nanoshimarobot
Since Method: annotated_pcd case will use t4_dataset input format, I think we needed to add ground_segmentation in here

USE_T4_DATASET = ("perception", "obstacle_segmentation", "perception_2d", "traffic_light")

ScenarioName: ground_segmentation-sample
ScenarioDescription: ground_segmentation-sample
SensorModel: aip_xx1
VehicleModel: jpntaxi

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you test with pilot-auto?

Suggested change
VehicleModel: jpntaxi
VehicleModel: lexus

@nanoshimarobot nanoshimarobot force-pushed the feat/ground_segmentation_pcd_eval branch from 634f47b to 6973d00 Compare August 19, 2024 06:33
Comment on lines 4 to 5
SensorModel: aip_xx1
VehicleModel: jpntaxi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because aip_xx1 and jpntaxi are TIER IV internal models, it is better to set them to sample_sensor_kit and sample_vehicle like other sample scenarios for perception tasks in driving_log_replayer.

SensorModel: sample_sensor_kit
VehicleModel: sample_vehicle

Comment on lines 9 to 13
// "/opt/ros/humble/include/**",
"driving_log_replayer/include/**"
// "${env:HOME}/ros_ws/awf/install/**",
// "/usr/include/**",
// "/usr/local/include/**"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Q] Are these comment out intended?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, those comments were unintentional. I have fixed them.

Copy link

sonarcloud bot commented Sep 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants