Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check DiagnosticArray status length #572

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

hayato-m126
Copy link
Collaborator

@hayato-m126 hayato-m126 commented Oct 9, 2024

Types of PR

  • Bugfix

Description

  • check status length if length == 0 return

How to review this PR

webauto ci scenario run --project-id prd_jt --scenario-id a0bed3d4-be44-4ca4-a21b-ff7bccfb9d48 --scenario-version-id 2

develop

[yabloc_evaluator_node.py-85] Traceback (most recent call last):
[yabloc_evaluator_node.py-85]   File "/home/autoware/pilot-auto/install/driving_log_replayer/lib/driving_log_replayer/yabloc_evaluator_node.py", line 54, in <module>
[yabloc_evaluator_node.py-85]     main()
[yabloc_evaluator_node.py-85]   File "/home/autoware/pilot-auto/install/driving_log_replayer/local/lib/python3.10/dist-packages/driving_log_replayer/evaluator.py", line 371, in wrapper
[yabloc_evaluator_node.py-85]     executor.spin()
[yabloc_evaluator_node.py-85]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 294, in spin
[yabloc_evaluator_node.py-85]     self.spin_once()
[yabloc_evaluator_node.py-85]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 794, in spin_once
[yabloc_evaluator_node.py-85]     self._spin_once_impl(timeout_sec)
[yabloc_evaluator_node.py-85]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 791, in _spin_once_impl
[yabloc_evaluator_node.py-85]     future.result()
[yabloc_evaluator_node.py-85]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/task.py", line 94, in result
[yabloc_evaluator_node.py-85]     raise self.exception()
[yabloc_evaluator_node.py-85]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/task.py", line 239, in __call__
[yabloc_evaluator_node.py-85]     self._handler.send(None)
[yabloc_evaluator_node.py-85]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 437, in handler
[yabloc_evaluator_node.py-85]     await call_coroutine(entity, arg)
[yabloc_evaluator_node.py-85]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 362, in _execute_subscription
[yabloc_evaluator_node.py-85]     await await_or_execute(sub.callback, msg)
[yabloc_evaluator_node.py-85]   File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 107, in await_or_execute
[yabloc_evaluator_node.py-85]     return callback(*args)
[yabloc_evaluator_node.py-85]   File "/home/autoware/pilot-auto/install/driving_log_replayer/lib/driving_log_replayer/yabloc_evaluator_node.py", line 41, in diagnostics_cb
[yabloc_evaluator_node.py-85]     diag_status = msg.status[0]
[yabloc_evaluator_node.py-85] IndexError: list index out of range

this PR

---
result              	true
log_path            	/home/hyt/.webauto/simulation/data/data_20241009172202_2851366249/log
duration            	145.57 sec

Others

Signed-off-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
@hayato-m126 hayato-m126 merged commit 5e7dd74 into develop Oct 9, 2024
6 checks passed
@hayato-m126 hayato-m126 deleted the fix/access-empty-list branch October 9, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants