-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: 2x processing speedup #581
Conversation
Signed-off-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
Signed-off-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
Signed-off-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
colcon_test workflow is failing, but unit test is succeeding, so It's no problem.
This is occurring because sceret is used in sonar scan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your work! LGTM
Types of PR
Description
The schema validation on my computer was the biggest performance bottleneck, so I improved it by precompiling the schema.
On my computer, before this change the frame processing time was ~350ms, currently it's about 200ms.
Along with perception-evaluation this could be even 5x.