Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: 2x processing speedup #581

Merged
merged 8 commits into from
Nov 1, 2024

Conversation

ralwing
Copy link
Contributor

@ralwing ralwing commented Oct 30, 2024

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Description

The schema validation on my computer was the biggest performance bottleneck, so I improved it by precompiling the schema.
On my computer, before this change the frame processing time was ~350ms, currently it's about 200ms.
Along with perception-evaluation this could be even 5x.

Signed-off-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
Signed-off-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
Signed-off-by: Hayato Mizushima <hayato-m126@users.noreply.github.com>
Copy link
Collaborator

@hayato-m126 hayato-m126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colcon_test workflow is failing, but unit test is succeeding, so It's no problem.
This is occurring because sceret is used in sonar scan.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work! LGTM

@hayato-m126 hayato-m126 merged commit 0794126 into tier4:develop Nov 1, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants