Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API usability improvements #184

Merged
merged 6 commits into from
Jun 2, 2024
Merged

API usability improvements #184

merged 6 commits into from
Jun 2, 2024

Conversation

tiffany352
Copy link
Owner

  • Added helper functions load_definitions() and load_currency() on Context to deduplicate code every frontend had to write out
  • Added ToSpans impl for Result<QueryReply, QueryError> to avoid a pointless looking match statement
  • Added more examples to the API docs
  • Fleshed out the API docs a bit more

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 82.55%. Comparing base (df8b961) to head (89deeb2).

Files Patch % Lines
cli/src/config.rs 66.66% 5 Missing ⚠️
rink-js/src/lib.rs 0.00% 3 Missing ⚠️
core/src/output/reply.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   81.97%   82.55%   +0.58%     
==========================================
  Files          42       42              
  Lines        7632     7636       +4     
==========================================
+ Hits         6256     6304      +48     
+ Misses       1376     1332      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tiffany352 tiffany352 marked this pull request as ready for review June 2, 2024 22:59
@tiffany352 tiffany352 merged commit db3f8d0 into master Jun 2, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant