Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degree cent #149

Merged
merged 11 commits into from
May 28, 2024
Merged

Degree cent #149

merged 11 commits into from
May 28, 2024

Conversation

RobRossmiller-TG
Copy link
Contributor

@RobRossmiller-TG RobRossmiller-TG commented May 28, 2024

PR Summary

  • Most of the 186 files are just moves. I removed the gsql_algorithms_baseline path in data/baseline.
  • Updated degree centrality to default to the normalized answer
    • Added normalize param to optionally revert to previous impl
  • Added baseline creation pattern via networkx

PR Checklist

  • [ x ] Added comments for more comprehensible code.
  • [ x ] Added unit and/or regression tests.
  • (Optional) Notified Doc/Prod team, if this PR contains any new features.

What is the behavior change?

Other information:

Related PRs:

@RobRossmiller-TG RobRossmiller-TG marked this pull request as ready for review May 28, 2024 15:31
@wyattjoynertg
Copy link
Contributor

If we're in the process of changing this query, I do have an optimization for readability and performance. Instead of a FOREACH loop of the edge types, GSQL's outdegree function supports a set of strings as a parameter. If we want to leave this kind of cleanup for another PR, that's fine as well, since it won't affect the output of the implementation.

@RobRossmiller-TG RobRossmiller-TG merged commit 356c36f into testing_updates May 28, 2024
2 checks passed
@RobRossmiller-TG RobRossmiller-TG deleted the degree-cent branch May 28, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants