set --disable-stats if stats feature is not enabled
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemalloc defaults to enabling stats if `--enable-stats` is not present and `--disable-stats` was not set: https://github.com/jemalloc/jemalloc/blob/fa451de17fff73cc03c31ec8cd817d62927d1ff9/configure.ac#L1331-L1333 Signed-off-by: strawberry <strawberry@puppygock.gay>
|
It's better to add it in the default feature list in this PR. This is still a breaking change for those rely on stats features without enabling it explicitly though. |
the stats feature was always enabled by default and never respected if someone were to remove the stats feature as no logic was added for setting `--disable-stats`. to avoid breaking other user's setups who are relying on this behaviour, set stats as a default feature. Signed-off-by: strawberry <strawberry@puppygock.gay>
|
@BusyJay Added it to the default features |
|
@BusyJay Anything blocking this PR from being merged? The CI failure looks to be out of my control, the runner timed out. Everything else still passed. |
BusyJay
approved these changes
May 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jemalloc defaults to enabling stats if
--enable-statsis not present and--disable-statswas not set: https://github.com/jemalloc/jemalloc/blob/fa451de17fff73cc03c31ec8cd817d62927d1ff9/configure.ac#L1331-L1333This issue was observed when we were building with
statsand noticed the output ofmalloc_stats_printwas basically the same.Before:
After:
