Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support event #150

Merged
merged 5 commits into from
Jul 14, 2023
Merged

feat: support event #150

merged 5 commits into from
Jul 14, 2023

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Jul 14, 2023

Signed-off-by: Andy Lok andylokandy@hotmail.com

  • Rename SpanRecord.event to SpanRecord.name.
  • Add Event type to represent single points in time during the span's lifetime.
  • Add Event support to minitrace-jaeger reporter.

Signed-off-by: Andy Lok <andylokandy@hotmail.com>
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@andylokandy andylokandy requested a review from zhongzc July 14, 2023 08:14
@coveralls
Copy link

coveralls commented Jul 14, 2023

Pull Request Test Coverage Report for Build 5552195935

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 86 of 99 (86.87%) changed or added relevant lines in 12 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 79.1%

Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/global_collector.rs 41 42 97.62%
minitrace/src/collector/mod.rs 6 7 85.71%
minitrace-macro/src/lib.rs 0 2 0.0%
minitrace/src/local/raw_span.rs 0 2 0.0%
minitrace-jaeger/src/lib.rs 6 13 46.15%
Files with Coverage Reduction New Missed Lines %
minitrace-jaeger/src/lib.rs 1 80.36%
minitrace/src/collector/global_collector.rs 2 97.89%
Totals Coverage Status
Change from base Build 5545815479: -0.2%
Covered Lines: 1476
Relevant Lines: 1866

💛 - Coveralls

Copy link
Collaborator

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

Signed-off-by: Andy Lok <andylokandy@hotmail.com>
zhongzc and others added 2 commits July 14, 2023 16:42
Signed-off-by: Andy Lok <andylokandy@hotmail.com>
@andylokandy andylokandy merged commit 7f7b70f into tikv:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants