Attach metadata to root span and entire propagate in the entire hierarchy #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotansimha
force-pushed
the
span-metadata
branch
from
820648e
to
dd1e808
Compare
Signed-off-by: Dotan Simha <dotansimha@gmail.com>
dotansimha
force-pushed
the
span-metadata
branch
from
dd1e808
to
cd27633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
#178 (comment)
With this PR, new custom metadata can be attached to every root
SpanContextcreated. This metadata is propagated to every child span within that context.It uses
dyn Anyto allow developers to pass any kind of data.The metadata is also available in
SpanRecord, and aReportercan use it and decide how/what to report.I tested it with my project, and this seems to work pretty well. I'm implementing a custom flow where multiple reporters are defined, and each one is associated with an
endpointin my project - so this way I can distinguish whatReporterto use.