Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make background interval config public #225

Merged
merged 4 commits into from
Jun 23, 2024
Merged

feat: make background interval config public #225

merged 4 commits into from
Jun 23, 2024

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Jun 22, 2024 •
edited
Loading

Signed-off-by: andylokandy andylokandy@hotmail.com

Closes #223

@andylokandy
feat: make background interval config public
2b9438b 
Signed-off-by: andylokandy <andylokandy@hotmail.com>
@andylokandy andylokandy requested a review from zhongzc June 22, 2024 07:48
@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9623934780

Details

  • 20 of 25 (80.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 79.073%
Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/global_collector.rs 19 20 95.0%
minitrace/src/collector/mod.rs 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
minitrace/src/collector/mod.rs 1 82.08%
Totals Coverage Status
Change from base Build 9623211702: -0.2%
Covered Lines: 1723
Relevant Lines: 2179
💛 - Coveralls

MrCroxx
MrCroxx approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥰

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9625753862

Details

  • 22 of 29 (75.86%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 78.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/global_collector.rs 19 20 95.0%
test-statically-disable/src/main.rs 0 1 0.0%
minitrace/src/collector/mod.rs 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
minitrace/src/collector/mod.rs 2 80.39%
minitrace/src/collector/global_collector.rs 5 94.21%
Totals Coverage Status
Change from base Build 9623211702: -0.3%
Covered Lines: 1711
Relevant Lines: 2167
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9625772971

Details

  • 23 of 31 (74.19%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 78.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/global_collector.rs 20 21 95.24%
test-statically-disable/src/main.rs 0 1 0.0%
minitrace/src/collector/mod.rs 3 9 33.33%
Files with Coverage Reduction New Missed Lines %
minitrace/src/collector/mod.rs 1 80.39%
Totals Coverage Status
Change from base Build 9623211702: -0.3%
Covered Lines: 1711
Relevant Lines: 2167
💛 - Coveralls

@andylokandy
fix
2f7d3ae 
Signed-off-by: andylokandy <andylokandy@hotmail.com>
@andylokandy
fix
a5436df 
Signed-off-by: andylokandy <andylokandy@hotmail.com>
@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9625815768

Details

  • 23 of 30 (76.67%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 78.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/global_collector.rs 20 21 95.24%
test-statically-disable/src/main.rs 0 1 0.0%
minitrace/src/collector/mod.rs 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
minitrace/src/collector/mod.rs 2 80.39%
Totals Coverage Status
Change from base Build 9623211702: -0.3%
Covered Lines: 1711
Relevant Lines: 2167
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9625819151

Details

  • 23 of 30 (76.67%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 78.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/global_collector.rs 20 21 95.24%
test-statically-disable/src/main.rs 0 1 0.0%
minitrace/src/collector/mod.rs 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
minitrace/src/collector/mod.rs 2 80.39%
Totals Coverage Status
Change from base Build 9623211702: -0.3%
Covered Lines: 1711
Relevant Lines: 2167
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9625823797

Details

  • 23 of 30 (76.67%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 78.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/global_collector.rs 20 21 95.24%
test-statically-disable/src/main.rs 0 1 0.0%
minitrace/src/collector/mod.rs 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
minitrace/src/collector/mod.rs 2 80.39%
Totals Coverage Status
Change from base Build 9623211702: -0.3%
Covered Lines: 1711
Relevant Lines: 2167
💛 - Coveralls

@andylokandy
fix
d6c967d 
Signed-off-by: andylokandy <andylokandy@hotmail.com>
@coveralls
Copy link

coveralls commented Jun 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9632270986

Details

  • 23 of 30 (76.67%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 78.957%
Changes Missing Coverage Covered Lines Changed/Added Lines %
minitrace/src/collector/global_collector.rs 20 21 95.24%
test-statically-disable/src/main.rs 0 1 0.0%
minitrace/src/collector/mod.rs 3 8 37.5%
Files with Coverage Reduction New Missed Lines %
minitrace/src/collector/mod.rs 2 80.39%
Totals Coverage Status
Change from base Build 9623211702: -0.3%
Covered Lines: 1711
Relevant Lines: 2167
💛 - Coveralls

@andylokandy andylokandy merged commit f34070b into tikv:master Jun 23, 2024
9 checks passed
@andylokandy andylokandy deleted the dev branch June 23, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongzc zhongzc zhongzc approved these changes

@MrCroxx MrCroxx MrCroxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

qa: missing parent span
4 participants
@andylokandy @coveralls @MrCroxx @zhongzc