Fix panics on reading entries by stale index.
#370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
bot
added
do-not-merge/work-in-progress
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot
bot
added
size/M
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot
bot
added
size/XXL
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
ti-chi-bot
bot
added
size/M
ti-chi-bot
bot
added
needs-1-more-lgtm
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
|
/test ? |
|
@wuhuizuo: The following commands are available to trigger required jobs:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test rust-nightly |
|
/test rust-stable |
|
/test rust-nightly |
overvenus
approved these changes
Nov 6, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
9 tasks
9 tasks
LykxSassinator
added a commit
to LykxSassinator/raft-engine
that referenced
this pull request
Nov 7, 2024
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
…373) Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #tikv/tikv#17383
What's Changed:
To address the corner case where a read thread encounters a panic due to reading with a stale index from the
Memtable, which has been updated by a background thread that has already purged the stale logs.