raft: paginate the unapplied config changes scan #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix potentially unlimited memory usage spike possible in raft.hup() which reads all unapplied committed entries in order to check that there are no unapplied config changes. This PR paginates this scan so that the spike is limited to MaxCommittedSizePerReady. It also terminates the scan early if a config change has been found. It is ported from etcd-io/raft#32. Signed-off-by: Neil Shen <overvenus@gmail.com>
tonyxuqqi
approved these changes
Oct 16, 2023
overvenus
commented
Oct 17, 2023
Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
force-pushed
the
pageinate-scan-conf-change
branch
from
87cdb8a to
83c5c43
Compare
tisonkun
added a commit
to tisonkun/mephisto-archive
that referenced
this pull request
Oct 18, 2023
Fix potentially unlimited memory usage spike possible in raft.hup() which reads all unapplied committed entries in order to check that there are no unapplied config changes. This PR paginates this scan so that the spike is limited to MaxCommittedSizePerReady. It also terminates the scan early if a config change has been found. It is ported from etcd-io/raft#32. It is ported from tikv/raft-rs#530. Signed-off-by: tison <wander4096@gmail.com>
tisonkun
added a commit
to tisonkun/mephisto-archive
that referenced
this pull request
Oct 18, 2023
Fix potentially unlimited memory usage spike possible in raft.hup() which reads all unapplied committed entries in order to check that there are no unapplied config changes. This PR paginates this scan so that the spike is limited to MaxCommittedSizePerReady. It also terminates the scan early if a config change has been found. It is ported from etcd-io/raft#32. It is ported from tikv/raft-rs#530. Signed-off-by: tison <wander4096@gmail.com>
overvenus
added a commit
to overvenus/tikv
that referenced
this pull request
Oct 20, 2023
Before start election, raft-rs has to check if there is any unapplied conf change entry. In the current implementation, this needs to scan logs from [unapplied_index, committed_index]. It essentially takes unbounded memory when raft peers that has many unapplied logs. To fix the issue, TiKV can paginate scan raft log which has a fixed memory usage upper bound. Cc tikv/raft-rs#530 Signed-off-by: Neil Shen <overvenus@gmail.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Oct 23, 2023
Before start election, raft-rs has to check if there is any unapplied conf change entry. In the current implementation, this needs to scan logs from [unapplied_index, committed_index]. It essentially takes unbounded memory when raft peers that has many unapplied logs. To fix the issue, TiKV can paginate scan raft log which has a fixed memory usage upper bound. Cc tikv/raft-rs#530 Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port from etcd-io/raft#32.
cc tikv/tikv#15770