fix vpc creation error (#246)

ignoring the error when vpc endpoint doesn't exist Signed-off-by: Sebastian Webber <sebastian@timescale.com>
timescale · Dec 3, 2024 · f3bbd20 · f3bbd20
1 parent 110ec4e
commit f3bbd20
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/internal/client/service.go b/internal/client/service.go
@@ -6,6 +6,7 @@ import (
 	"errors"
 	"fmt"
 	"math/big"
+	"strings"
 
 	"github.com/hashicorp/terraform-plugin-log/tflog"
 )
@@ -169,7 +170,7 @@ func (c *Client) CreateService(ctx context.Context, request CreateServiceRequest
 	if err := c.do(ctx, req, &resp); err != nil {
 		return nil, err
 	}
-	if len(resp.Errors) > 0 {
+	if len(resp.Errors) > 0 && !strings.Contains(resp.Errors[0].Message, "no Endpoint for that service id exists") {
 		return nil, resp.Errors[0]
 	}
 	if resp.Data == nil {

diff --git a/internal/provider/service_resource.go b/internal/provider/service_resource.go
@@ -304,9 +304,6 @@ func (r *ServiceResource) Create(ctx context.Context, req resource.CreateRequest
 		EnableConnectionPooler: plan.ConnectionPoolerEnabled.ValueBool(),
 		EnvironmentTag:         plan.EnvironmentTag.ValueString(),
 	}
-	if !plan.VpcID.IsNull() {
-		request.VpcID = plan.VpcID.ValueInt64()
-	}
 
 	readReplicaSource := plan.ReadReplicaSource.ValueString()
 	if readReplicaSource != "" {
@@ -336,6 +333,10 @@ func (r *ServiceResource) Create(ctx context.Context, req resource.CreateRequest
 		}
 	}
 
+	if !plan.VpcID.IsNull() {
+		request.VpcID = plan.VpcID.ValueInt64()
+	}
+
 	response, err := r.client.CreateService(ctx, request)
 
 	if err != nil {