feat: remove restrictions on pg17 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevian
force-pushed
the
pg17_fixes
branch
6 times, most recently
from
eaaef73 to
5cbdca2
Compare
Upgrades alpine for pg17 to 3.21 since 3.20 is missing some packages like postgresql17-plpython3. Keeping old versions on 3.20 to ensure maximum backwards compatibility.
jgpruitt
approved these changes
Dec 11, 2024
svenklemm
reviewed
Dec 11, 2024
Comment on lines
+8
to
+10
| ifeq ($(shell test $(PG_MAJOR_VERSION) -ge 17; echo $$?),0) | ||
| ALPINE_VERSION=3.21 | ||
| CLANG_VERSION=19 |
There was a problem hiding this comment.
should we always do latest here at least for pg17?
There was a problem hiding this comment.
I think the clang version is fixed by the alpine one and I want to fix the OS version I think
svenklemm
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades alpine for pg17 to 3.21 since 3.20 is missing some packages
like postgresql17-plpython3. Keeping old versions on 3.20 to ensure
maximum backwards compatibility.