#155 fixing undefined reading bind #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryuni
requested changes
Nov 28, 2024
Comment on lines
-180
to
+182
| scenarioContext.addExternalObject(new CucumberLog(this.log.bind(this))); | ||
| scenarioContext.addExternalObject(new CucumberLog(this.log?.bind(this))); | ||
| scenarioContext.addExternalObject( | ||
| new CucumberAttachments(this.attach.bind(this)) | ||
| new CucumberAttachments(this.attach?.bind(this)) |
There was a problem hiding this comment.
The optional chaining would instantiate the classes with an invalid state. They should be checked and instantiated only if the functions exist:
if (this.log) scenarioContext.addExternalObject(new CucumberLog(this.log.bind(this)));And the same for attachments
Fryuni
reviewed
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binding-decorator.tsnpm audit fix