Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for self-restreams #185

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Allow for self-restreams #185

merged 1 commit into from
Nov 23, 2024

Conversation

Javantea
Copy link
Contributor

Self-restreams by allowing the player to not have the combot even if the producer has combot on.

A good example of the bug this fixes is where the player has three browser windows open:

The self-restreamer will hear the combot give score updates twice. It would be easy to mute if Firefox didn't use TTS server to do TTS instead of something that was mutable.

This patch allows the user to use this url to override the iframe's combot value:
http://localhost:5000/room/u/player1/producer?combot=0

It also allows the player to choose combot when the producer has the combot off which is an added bonus.

I would like to make this easier to use (self-restream button) but this is the first step in making the rest of those changes.

@timotheeg
Copy link
Owner

Hey Javantea, thanks for that! I wasn't sure anyone was actually using the commentator bot LOL 😅 . In fact, could I check with you: where did you hear the complaint or feature request?

Seeing your PR, my first reaction would be to hardcode-disable the commentator bot in the room renderer (just like stack rabbit / simultetris are always disabled) 🤔 . My reasoning for that is that players other than the streamer might also be annoyed at hearing the commentator bot speaking locally (real-time), but also delayed from the twitch stream (that they might also be listening to).

So I think I'll flip the logic on its head for now 🤔

  1. disable commentator by default in the room renderer for everyone
  2. independently of what the game host is doing, allow players to activate the commentator bot if they wish, by adding combot=1 to the producer page url

@timotheeg timotheeg merged commit b797e3c into timotheeg:main Nov 23, 2024
@timotheeg
Copy link
Owner

Done and merged!

@Javantea
Copy link
Contributor Author

Many thanks for creating a sensible solution. I just tested both and both work. I'll test with two players later but I'm confident that it'll work. This will definitely enable me to work on improvements.
I was the original bug finder. I was not able to find a restreamer for my DAS Masters match vs Vlad Maksimum and had to self-restream. Multiple games went into 19 so I didn't know what score he topped out while I was chasing on 19. I tested NTC because I knew it had commentary bot and found that bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants