Handles case with semi-deterministic elements

tingiskhan · Nov 14, 2024 · 29fb53d · 29fb53d
1 parent b4f43b0
commit 29fb53d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/skyro/_mixin.py b/skyro/_mixin.py
@@ -194,7 +194,11 @@ def _process_results(self, mcmc: MCMC) -> NumpyroResultSet:
 
         # TODO: need to handle case when some of the dimensions of the variables are nan
         for name, summary_ in s.items():
-            if (summary_["r_hat"] <= self.max_rhat).all():
+            # NB: some variables have deterministic elements (s.a. samples from LKJCov).
+            mask = np.isnan(summary_["n_eff"])
+            r_hat = summary_["r_hat"][~mask]
+
+            if (r_hat <= self.max_rhat).all():
                 continue
 
             raise ConvergenceError(f"Parameter '{name}' did not converge!")